move all mqtt publishing functions to mqtt module

- fix: use tagged enum serialization for TankError
- fix: rename TankInfo fields for consistent naming (volume_ml, pct, water_temp_c)
- renamed some fields for better clarity on contained value

rust/src/main.rs

@@ -415,10 +415,10 @@ async fn safe_main(spawner: Spawner) -> FatResult<()> {
                     .get_esp()
                     .store_last_pump_time(plant_id, cur);
                 board.board_hal.get_esp().last_pump_time(plant_id);
-                mqtt::pump_info(plant_id, true, pump_ineffective, 0, 0, 0, false).await;
+                pump_info(plant_id, true, pump_ineffective, 0, 0, 0, false).await;
                 let result = do_secure_pump(&mut board, plant_id, plant_config, dry_run).await?;
                 board.board_hal.pump(plant_id, false).await?;
-                mqtt::pump_info(
+                pump_info(
                     plant_id,
                     false,
                     pump_ineffective,
@@ -561,8 +561,7 @@ async fn safe_main(spawner: Spawner) -> FatResult<()> {
 
     if stay_alive {
         let reboot_now = Arc::new(AtomicBool::new(false));
-
-        spawner.spawn(http_server(reboot_now.clone(), stack.take().unwrap())?);
+        let _webserver = http_server(reboot_now.clone(), stack.take().unwrap());
         wait_infinity(board, WaitType::MqttConfig, reboot_now.clone(), UTC).await;
     } else {
         //TODO wait for all mqtt publishes?

rust/src/plant_state.rs

@@ -300,7 +300,7 @@ impl PlantState {
                 false
             },
             cooldown: self.pump_in_timeout(plant_conf, current_time),
-            out_of_work_hour: !in_time_range(
+            out_of_work_hour: in_time_range(
                 current_time,
                 plant_conf.pump_hour_start,
                 plant_conf.pump_hour_end,