Refactor async logging to synchronous; improve error handling consistency across modules.

Software/MainBoard/rust/src/log/interceptor.rs

@@ -3,7 +3,7 @@ use alloc::vec::Vec;
 use embassy_sync::blocking_mutex::raw::CriticalSectionRawMutex;
 use embassy_sync::blocking_mutex::Mutex as BlockingMutex;
 use embassy_sync::mutex::Mutex;
-use log::{LevelFilter, Log, Metadata, Record};
+use log::{error, LevelFilter, Log, Metadata, Record};
 
 pub struct InterceptorLogger {
     // Async mutex for start/stop capture from async context
@@ -34,9 +34,13 @@ impl InterceptorLogger {
     }
 
     pub fn init(&'static self) {
-        log::set_logger(self)
-            .map(|()| log::set_max_level(LevelFilter::Info))
-            .unwrap();
+        match log::set_logger(self)
+            .map(|()| log::set_max_level(LevelFilter::Info)) {
+            Ok(()) => {}
+            Err(e) => {
+                error!("Logger already set: {}", e);
+            }
+        }
     }
 }
 

Software/MainBoard/rust/src/log/mod.rs

@@ -115,28 +115,25 @@ impl From<LogEntryInner> for LogEntry {
     }
 }
 
-pub async fn log(
-    message_key: LogMessage,
-    number_a: u32,
-    number_b: u32,
-    txt_short: &str,
-    txt_long: &str,
-) {
+pub fn log(message_key: LogMessage, number_a: u32, number_b: u32, txt_short: &str, txt_long: &str) {
     let mut txt_short_stack: heapless::String<TXT_SHORT_LENGTH> = heapless::String::new();
     let mut txt_long_stack: heapless::String<TXT_LONG_LENGTH> = heapless::String::new();
 
     limit_length(txt_short, &mut txt_short_stack);
     limit_length(txt_long, &mut txt_long_stack);
 
-    LOG_CHANNEL
-        .send(LogRequest {
-            message_key,
-            number_a,
-            number_b,
-            txt_short: txt_short_stack,
-            txt_long: txt_long_stack,
-        })
-        .await;
+    match LOG_CHANNEL.try_send(LogRequest {
+        message_key,
+        number_a,
+        number_b,
+        txt_short: txt_short_stack,
+        txt_long: txt_long_stack,
+    }) {
+        Ok(_) => {}
+        Err(_) => {
+            warn!("Log channel full, dropping log entry");
+        }
+    }
 }
 
 impl LogArray {
@@ -316,6 +313,10 @@ pub enum LogMessage {
     PumpMissingSensorCurrent,
     #[strum(serialize = "MPPT Current sensor could not be reached")]
     MPPTError,
+    #[strum(
+        serialize = "Trace: a: ${number_a} b: ${number_b} txt_s ${txt_short} long ${txt_long}"
+    )]
+    Trace,
     #[strum(serialize = "Parsing error reading message")]
     UnknownMessage,
 }