import json import pytest from ccma.storage.repository import ( MemberRepository, RepositoryError, format_member_number, validate_member_number_pattern, ) def test_repository_creates_transparent_member_record(tmp_path) -> None: repository = MemberRepository(tmp_path / "store") repository.initialize() assert (repository.root / "templates").is_dir() member = repository.create_member( first_name="Ada", last_name="Lovelace", email="ada@example.org", birth_date="1990-12-10", member_number="0042", ) member_dir = repository.members_root / member.member_id assert (member_dir / "member.json").is_file() assert (member_dir / "contributions.json").is_file() assert (member_dir / "events.jsonl").is_file() assert (member_dir / "files").is_dir() assert repository.validate() == [] raw = json.loads((member_dir / "member.json").read_text(encoding="utf-8")) assert raw["person"]["first_name"] == "Ada" assert raw["schema_version"] == 1 def test_search_matches_name_email_number_and_german_birth_date(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() member = repository.create_member( first_name="Jörg", last_name="Müller", email="joerg.mueller@example.org", birth_date="1990-04-23", member_number="C3-007", ) for query in ("Jorg Muller", "mueller@example.org", "C3-007", "23.04.1990"): assert [result.member_id for result in repository.search(query)] == [member.member_id] def test_events_are_appended_and_changes_do_not_leak_values(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() member = repository.create_member(first_name="Alice", last_name="Example", email="old@example.org") member.email = "new@example.org" repository.save_member(member) repository.append_event( member.member_id, event_type="board_comment", summary="Telefonisch erreicht", actor_type="user", actor_name="Vorstand", ) events = repository.get_events(member.member_id) assert [event.event_type for event in events] == [ "member_created", "member_data_changed", "board_comment", ] assert "E-Mail-Adresse" in events[1].summary assert "old@example.org" not in events[1].summary assert "new@example.org" not in events[1].summary def test_status_change_audit_contains_old_and_new_status(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() member = repository.create_member(first_name="Status", last_name="Test") member.status = "active" repository.save_member(member) event = repository.get_events(member.member_id)[-1] assert event.summary == "Mitgliedsdaten geändert: Status von ANTRAG zu AKTIV" def test_repository_accepts_local_date_input_and_rejects_invalid_dates(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() member = repository.create_member(first_name="Local", last_name="Date", birth_date="31.12.2000") assert member.birth_date == "2000-12-31" assert repository.get_member(member.member_id).birth_date == "2000-12-31" with pytest.raises(RepositoryError, match="gültiges Datum"): repository.create_member(first_name="Invalid", last_name="Date", birth_date="31.02.2000") def test_repository_reports_empty_contributions_file(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() member = repository.create_member(first_name="Empty", last_name="Contributions") path = repository.members_root / member.member_id / "contributions.json" path.write_text("", encoding="utf-8") with pytest.raises(RepositoryError, match="contributions.json konnte nicht gelesen"): repository.get_contributions(member.member_id) assert any("contributions.json" in error for error in repository.validate()) def test_repository_rejects_structurally_invalid_member_json(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() member = repository.create_member(first_name="Invalid", last_name="Structure") path = repository.members_root / member.member_id / "member.json" raw = json.loads(path.read_text(encoding="utf-8")) raw["person"] = [] path.write_text(json.dumps(raw), encoding="utf-8") with pytest.raises(RepositoryError, match="person muss ein JSON-Objekt sein"): repository.preflight_member_record(member.member_id) def test_member_path_rejects_traversal(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() with pytest.raises(RepositoryError): repository.get_member("../outside") def test_automatic_member_numbers_are_sequential_and_preview_does_not_consume(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() assert repository.preview_member_number() == "CCMA-0001" assert repository.preview_member_number() == "CCMA-0001" first = repository.create_member(first_name="First", last_name="Member") second = repository.create_member(first_name="Second", last_name="Member") assert first.member_number == "CCMA-0001" assert second.member_number == "CCMA-0002" assert repository.preview_member_number() == "CCMA-0003" def test_custom_pattern_and_manual_mode(tmp_path) -> None: repository = MemberRepository(tmp_path) repository.initialize() repository.save_member_number_policy(mode="automatic", pattern="MA-{year}-{number:03d}") automatic = repository.create_member(first_name="Auto", last_name="Member") assert automatic.member_number.startswith("MA-") assert automatic.member_number.endswith("-001") repository.save_member_number_policy(mode="manual", pattern="MA-{number:03d}") with pytest.raises(RepositoryError, match="erforderlich"): repository.create_member(first_name="Missing", last_name="Number") manual = repository.create_member(first_name="Manual", last_name="Member", member_number="SPECIAL-7") assert manual.member_number == "SPECIAL-7" with pytest.raises(RepositoryError, match="bereits vergeben"): repository.create_member(first_name="Duplicate", last_name="Member", member_number="special-7") @pytest.mark.parametrize("pattern", ["", "CCMA-{year}", "{unknown}-{number}", "{number!r}"]) def test_invalid_member_number_patterns_are_rejected(pattern) -> None: with pytest.raises(RepositoryError): validate_member_number_pattern(pattern) def test_member_number_formatter_supports_padding_and_year() -> None: assert format_member_number("CCMA-{year}-{number:05d}", 42, year=2026) == "CCMA-2026-00042"