feat: add staged reminder workflow

This commit is contained in:
Marcel Peterkau
2026-06-21 18:40:54 +02:00
parent 288b5f6247
commit e6d2f77d1e
9 changed files with 630 additions and 43 deletions
+15 -3
View File
@@ -105,19 +105,31 @@ def test_payment_can_be_split_across_multiple_claims(tmp_path) -> None:
def test_reminder_fee_increases_claim_and_is_audited(tmp_path) -> None:
repository, member = _repository_with_claim(tmp_path)
reminder = repository.add_reminder(
reminder = repository.create_reminder_draft(
member.member_id,
"claim-1",
level=1,
name="Zahlungserinnerung",
payment_deadline_days=14,
detail="Per E-Mail versandt",
fee="5.00",
)
data, claim = repository.get_claim(member.member_id, "claim-1")
assert claim_total(claim) == Decimal("100.00")
assert reminder["status"] == "draft"
assert reminder["fee_item_id"] is None
repository.mark_reminder_sent(member.member_id, "claim-1", reminder["reminder_id"])
data, claim = repository.get_claim(member.member_id, "claim-1")
sent = data.reminders[0]
assert claim_total(claim) == Decimal("105.00")
assert reminder["fee_item_id"]
assert sent["status"] == "sent"
assert sent["payment_deadline"]
assert sent["fee_item_id"]
assert data.reminders[0]["detail"] == "Per E-Mail versandt"
assert repository.get_events(member.member_id)[-1].event_type == "reminder_created"
assert repository.get_events(member.member_id)[-1].event_type == "reminder_sent"
def test_claim_with_payment_cannot_be_cancelled(tmp_path) -> None:
+5 -1
View File
@@ -29,7 +29,11 @@ def test_housekeeper_reports_initial_payment_and_open_claims(tmp_path) -> None:
)
findings = Housekeeper(repository).run(today=date(2026, 2, 10))
assert {finding.code for finding in findings} == {"initial_payment_overdue", "claim_overdue"}
assert {finding.code for finding in findings} == {
"initial_payment_overdue",
"claim_overdue",
"reminder_due",
}
def test_housekeeper_reports_birthdays_before_today_and_after(tmp_path) -> None:
+136
View File
@@ -0,0 +1,136 @@
from datetime import date, timedelta
import pytest
from ccma.domain.models import ContributionData
from ccma.services.housekeeper import Housekeeper
from ccma.storage.repository import MemberRepository, RepositoryError
def _overdue_claim_repository(tmp_path):
repository = MemberRepository(tmp_path)
repository.initialize()
member = repository.create_member(first_name="Reminder", last_name="Test", birth_date="1990-01-01")
repository.save_contributions(
member.member_id,
ContributionData(
claims=[
{
"claim_id": "claim-1",
"claim_key": "overdue-test",
"title": "Offene Forderung",
"amount": "100.00",
"due_date": "2026-01-31",
"status": "open",
}
]
),
)
return repository, member
def test_reminder_rule_progresses_only_after_sent_deadline(tmp_path) -> None:
repository, member = _overdue_claim_repository(tmp_path)
housekeeper = Housekeeper(repository)
findings = housekeeper.run(today=date(2026, 2, 10))
reminder_task = next(item for item in findings if item.code == "reminder_due")
assert "Zahlungserinnerung" in reminder_task.title
draft = repository.create_reminder_draft(
member.member_id,
"claim-1",
level=1,
name="Zahlungserinnerung",
payment_deadline_days=14,
fee="0.00",
)
findings = housekeeper.run(today=date(2026, 2, 10))
reminder_task = next(item for item in findings if item.code == "reminder_due")
assert "wartet auf Versand" in reminder_task.title
sent = repository.mark_reminder_sent(member.member_id, "claim-1", draft["reminder_id"])
deadline = date.fromisoformat(sent["payment_deadline"])
assert not any(
item.code == "reminder_due" for item in housekeeper.run(today=deadline - timedelta(days=1))
)
findings = housekeeper.run(today=deadline)
next_task = next(item for item in findings if item.code == "reminder_due")
assert "Erste Mahnung" in next_task.title
def test_dunning_hold_suppresses_and_then_restores_task(tmp_path) -> None:
repository, member = _overdue_claim_repository(tmp_path)
housekeeper = Housekeeper(repository)
repository.set_dunning_hold(
member.member_id,
"claim-1",
active=True,
reason="Betrag wird geklärt",
)
assert not any(item.code == "reminder_due" for item in housekeeper.run(today=date(2026, 2, 10)))
with pytest.raises(RepositoryError, match="Mahnsperre aktiv"):
repository.create_reminder_draft(
member.member_id,
"claim-1",
level=1,
name="Zahlungserinnerung",
payment_deadline_days=14,
)
repository.set_dunning_hold(member.member_id, "claim-1", active=False)
assert any(item.code == "reminder_due" for item in housekeeper.run(today=date(2026, 2, 10)))
def test_draft_can_be_cancelled_but_sent_reminder_cannot(tmp_path) -> None:
repository, member = _overdue_claim_repository(tmp_path)
draft = repository.create_reminder_draft(
member.member_id,
"claim-1",
level=1,
name="Zahlungserinnerung",
payment_deadline_days=14,
)
repository.cancel_reminder(member.member_id, "claim-1", draft["reminder_id"])
data = repository.get_contributions(member.member_id)
assert data.reminders[0]["status"] == "cancelled"
second = repository.create_reminder_draft(
member.member_id,
"claim-1",
level=1,
name="Zahlungserinnerung",
payment_deadline_days=14,
)
repository.mark_reminder_sent(member.member_id, "claim-1", second["reminder_id"])
with pytest.raises(RepositoryError, match="bereits versandte"):
repository.cancel_reminder(member.member_id, "claim-1", second["reminder_id"])
def test_reminder_levels_cannot_be_skipped(tmp_path) -> None:
repository, member = _overdue_claim_repository(tmp_path)
with pytest.raises(RepositoryError, match="Mahnstufe 1 wurde noch nicht versandt"):
repository.create_reminder_draft(
member.member_id,
"claim-1",
level=2,
name="Erste Mahnung",
payment_deadline_days=14,
fee="5.00",
)
def test_payment_resolves_open_reminder_task(tmp_path) -> None:
repository, member = _overdue_claim_repository(tmp_path)
housekeeper = Housekeeper(repository)
assert any(item.code == "reminder_due" for item in housekeeper.run(today=date(2026, 2, 10)))
repository.record_payment(
member.member_id,
"claim-1",
payment_date="2026-02-10",
amount="100.00",
allocation_amount="100.00",
)
findings = housekeeper.run(today=date(2026, 2, 10))
assert not any(item.code == "reminder_due" for item in findings)