ui: move payment frequency to banking tab

src/ccma/ui/member_tab.py

@@ -204,22 +204,11 @@ class MemberTab(ttk.Frame):
             state="readonly",
             width=39,
         ).grid(row=len(fields), column=1, sticky="ew", pady=5)
-        self._add_variable("payment_frequency", tk.StringVar(), "data")
-        ttk.Label(data_tab, text="Zahlweise").grid(
-            row=len(fields) + 1, column=0, sticky="w", pady=5, padx=(0, 12)
-        )
-        ttk.Combobox(
-            data_tab,
-            textvariable=self.variables["payment_frequency"],
-            values=list(PAYMENT_FREQUENCY_LABELS.values()),
-            state="readonly",
-            width=39,
-        ).grid(row=len(fields) + 1, column=1, sticky="ew", pady=5)
         ttk.Label(data_tab, text="Interne Notiz").grid(
-            row=len(fields) + 2, column=0, sticky="nw", pady=5, padx=(0, 12)
+            row=len(fields) + 1, column=0, sticky="nw", pady=5, padx=(0, 12)
         )
         self.notes_text = tk.Text(data_tab, width=42, height=6, wrap="word")
-        self.notes_text.grid(row=len(fields) + 2, column=1, sticky="ew", pady=5)
+        self.notes_text.grid(row=len(fields) + 1, column=1, sticky="ew", pady=5)
         self.notes_text.bind("<<Modified>>", lambda _event: self._mark_dirty_from_text("data"), add="+")
         data_tab.columnconfigure(1, weight=1)
 
@@ -247,7 +236,18 @@ class MemberTab(ttk.Frame):
             (f"Mandat widerrufen am ({date_input_hint()})", "mandate_revoked_at"),
         )
         banking_tab.columnconfigure(1, weight=1)
-        for row, (label, key) in enumerate(banking_fields):
+        self._add_variable("payment_frequency", tk.StringVar(), "banking")
+        ttk.Label(banking_tab, text="Zahlweise").grid(
+            row=0, column=0, sticky="w", padx=(0, 12), pady=5
+        )
+        ttk.Combobox(
+            banking_tab,
+            textvariable=self.variables["payment_frequency"],
+            values=list(PAYMENT_FREQUENCY_LABELS.values()),
+            state="readonly",
+            width=39,
+        ).grid(row=0, column=1, sticky="ew", pady=5)
+        for row, (label, key) in enumerate(banking_fields, start=1):
             self._add_variable(key, tk.StringVar(), "banking")
             ttk.Label(banking_tab, text=label).grid(row=row, column=0, sticky="w", padx=(0, 12), pady=5)
             ttk.Entry(banking_tab, textvariable=self.variables[key], width=42).grid(
@@ -259,7 +259,7 @@ class MemberTab(ttk.Frame):
             text="SEPA-Lastschriftmandat ist aktiv",
             variable=self.variables["mandate_active"],
             style="Switch",
-        ).grid(row=len(banking_fields), column=0, columnspan=2, sticky="w", pady=(12, 5))
+        ).grid(row=len(banking_fields) + 1, column=0, columnspan=2, sticky="w", pady=(12, 5))
         contribution_tab.columnconfigure(0, weight=1)
         contribution_tab.rowconfigure(1, weight=1)
         self.contribution_summary = tk.StringVar()