From 4e642a4421603a4125fa6929d760abedc9f41767 Mon Sep 17 00:00:00 2001
From: ju6ge <judge@felixrichter.tech>
Date: Thu, 27 Feb 2025 21:58:30 +0100
Subject: [PATCH] simply wait loop logic

---
 rust/src/main.rs | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/rust/src/main.rs b/rust/src/main.rs
index d1fbf6b..9e462fa 100644
--- a/rust/src/main.rs
+++ b/rust/src/main.rs
@@ -932,11 +932,10 @@ fn wait_infinity(wait_type: WaitType, reboot_now: Arc<AtomicBool>) -> ! {
 
     let mut led_count = 8;
     loop {
+        // TODO implement actually different blink patterns instead of modulating blink duration
         if wait_type == WaitType::MissingConfig {
+            led_count %= 8;
             led_count += 1;
-            if led_count > 8 {
-                led_count = 1;
-            }
         };
         unsafe {
             //do not trigger watchdog
@@ -946,17 +945,14 @@ fn wait_infinity(wait_type: WaitType, reboot_now: Arc<AtomicBool>) -> ! {
             BOARD_ACCESS.lock().unwrap().general_fault(true);
             vTaskDelay(delay);
             BOARD_ACCESS.lock().unwrap().general_fault(false);
+            //TODO move locking outside of loop and drop afterwards
             for i in 0..8 {
                 BOARD_ACCESS.lock().unwrap().fault(i, false);
             }
             vTaskDelay(delay);
-            match wait_type {
-                WaitType::MissingConfig => {}
-                WaitType::ConfigButton => {}
-                WaitType::MqttConfig => {
-                    if !STAY_ALIVE.load(std::sync::atomic::Ordering::Relaxed) {
-                        reboot_now.store(true, std::sync::atomic::Ordering::Relaxed);
-                    }
+            if wait_type == WaitType::MqttConfig {
+                if !STAY_ALIVE.load(std::sync::atomic::Ordering::Relaxed) {
+                    reboot_now.store(true, std::sync::atomic::Ordering::Relaxed);
                 }
             }
             if reboot_now.load(std::sync::atomic::Ordering::Relaxed) {